[FIXED] Bug: Polyphony, PWM, ADSR

Bug Reporting
Post Reply
MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

[FIXED] Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 27 Apr 2009 22:49

Polyphony: [fixed!]
http://commandante.fwsnet.net/padelicious_fixme.zip

PWM bug: [still working on this]
sometimes modulating PWM results in clicks
ive found that some combinations just dont match creating "strange" waveforms
but i remember sometimes it wasnt supposed to be there

ADSR bug: [fixed!]
the good old, that i never seem to be able to remember to save :P
(not related to filter, as im aware using attack there is kind of self-destructive :P )
Last edited by MadGonzo on 21 May 2009 23:42, edited 3 times in total.

MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

Re: Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 07 May 2009 16:55

found the polyphony bug:
Legato sometimes creates clicking
Polyphony lower than actual notes that will be played creates clicking
100%, always. :P

every time the synth uses "oldest" note, it will click
you probably have a standard queuing system, where oldest gets reused
try with trigger on if you cant make it bug, i havent "investigated" extensively
but ive found that its surprisingly easy to make the bug appear
this bug also ruined my "padelicious" songs all the time :P

Please fix

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 07 May 2009 22:19

MadGonzo wrote: Legato sometimes creates clicking
This can happen, depending on the patch...but I would say if it doesn't click in mono it shouldn't click in legato mode either.
MadGonzo wrote: Polyphony lower than actual notes that will be played creates clicking
100%, always. :P
The system first searches for non-used (free and silent) voices.
If none are found, it tries find the voice with the key that was released the longest time ago
(as you might recall, this was added in v1.02, viewtopic.php?f=14&t=322&start=0).
If no voices are found (i.e., all voices have held keys), it gives up and chooses the "next" voice according to an internal index count.

The last choice will result in a click. No question. So this is not neccesarily a bug, but I will try your patch. :D

MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

Re: Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 08 May 2009 22:49

well its first and foremost the actual clicking sound, for lack of a better description, thats worrying
it doesnt sound like a natural side effect of what im talking about
and, this naturally isnt there in any other VST
its just an annoying bug :P that needs to be dealt with

edit: helps turninig filter to 0, so you can hear it and believe it :P

btw is it natural for "trigger" on a generator to create a little click?
trigger is my best friend when it comes to super awesome pluck leads
i have to do my best to get rid of the click, making it inaudible

and last but not least, i cant figure out why padelicious wont bug in that project
though i did post the song i made no? it definitely bugs there.. alot

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 09 May 2009 01:25

MadGonzo wrote:well its first and foremost the actual clicking sound, for lack of a better description, thats worrying
it doesnt sound like a natural side effect of what im talking about
and, this naturally isnt there in any other VST
its just an annoying bug :P that needs to be dealt with
right on! :D if possible please send me an example my email 8)
MadGonzo wrote: btw is it natural for "trigger" on a generator to create a little click?
trigger is my best friend when it comes to super awesome pluck leads
i have to do my best to get rid of the click, making it inaudible
Osc trigger resets the phase, and by default can cause click. This is intended. One way to hide it is to have a short smooth attack env curve.
MadGonzo wrote: and last but not least, i cant figure out why padelicious wont bug in that project though i did post the song i made no? it definitely bugs there.. alot
Perhaps send me your "padelicious" too as fxp, just to be sure we have the exact same settings.

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 10 May 2009 11:04

karmafx wrote: Perhaps send me your "padelicious" too as fxp, just to be sure we have the exact same settings.
I cannot load your project, since your FL studio version is newer than the demo version available for download. :oops: :cry: So, unless you have a better idea, please send me the .fxp and the .mid that fits, and I'll try to render it a couple of times and check for clicks.

MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

Re: Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 10 May 2009 12:48

http://commandante.fwsnet.net/wipinstrus/
its not the same instrument, rather a derivation of it
should have the same mechanics
use it within a DAW, and try playing from uncommon positions along song
i never get the bug just by playing notes :P

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 11 May 2009 21:09

Thanks !!

I've played it live both in legato and poly mode for more than 30 minutes, but haven't gotten it to "click"... :?

When you say:
MadGonzo wrote:and try playing from uncommon positions along song
Do you mean than it happens on transport change..ie pressing stop/play or moving the position marker inside the host? And if so, does it just click once, or continue to click on every note?

Another thing I'm interested in... When you hear clicks, does toggling the Clk option on the ADSR make any difference?

MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

Re: Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 12 May 2009 22:54

well, rationally, you should be able to figure out the bug just from hearing the
actual song as rendered:
http://commandante.fwsnet.net/backtoearth2009.mp3

GLARING bug :P listen to the "soft party" where padelicious starts coming into action
its pretty much randomly not portamentoing right all the way...
maybe its a portamento bug? (personally, i doubt it)

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 13 May 2009 08:40

I can hear what you mean, but I need to reproduce in order to determine if it is a bug and fix it...an finally to assess wether the fix works. :lol: :roll:
If you can send me that part as mid and the fxp, I would be grateful. 8)

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 13 May 2009 11:02

Sorry, seems I accidentaly deleted you last post. :oops: But I have the .mid now. Thanks! 8)
I'll test it with the paddy.fxp you sent earlier.

karmafx
Site Admin
Posts: 1181
Joined: 07 Mar 2005 16:37

Re: Bug: Polyphony, PWM, ADSR

Post by karmafx » 13 May 2009 15:32

I've sent you a pm!

MadGonzo
Posts: 296
Joined: 07 Jun 2008 23:14

Re: Bug: Polyphony, PWM, ADSR

Post by MadGonzo » 21 May 2009 21:08

updated post, especially because of recent fixes and improvements to the vsti :)

Post Reply